Skip to content

Need to ensure we use lower-case gRPC header keys #1545

Description

@omaray

This might be a no-op, but please double check. Filing this issue just in case.

We need to ensure that all headers used for gRPC are written in lower-case. Please review this Pull Request for reference of what needs to be updated.

Again, perhaps this doesn't apply to your language. Feel free to comment and then close the issue (after double checking).

Activity

  1. stephenplusplus commented on Aug 30, 2016

    @stephenplusplus
    Contributor

    This is actually quite well timed, since we just got an issue about setting headers for Datastore: #1542. That issue already specifies the headers as lowercase, so I'll just be copying from that example.

    As our library stands currently, we don't set any headers at all. That's handled in gRPC for us, we just give it an auth client from google-auth-library and it figures out the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions