Skip to content

Language system-test fails because of returning Promise #1716

Closed
Closed
Language system-test fails because of returning Promise#1716
Assignees
stephenplusplus
Labels
api: languageIssues related to the Cloud Natural Language API API.

Description

@jmuk
jmuk
opened on Oct 18, 2016

Environment details

  • OS: Linux
  • Node.js version: v6.8.1
  • npm version: 3.10.8
  • google-cloud-node version: language / 0.3.0

Steps to reproduce

  1. cd packages/language
  2. npm run system-test (under proper environment variables)

Failures

  1) Language "after all" hook:
     TypeError: GCS.getBuckets(...).on is not a function
      at Context.<anonymous> (system-test/language.js:60:8)

As I quickly reviewed, GCS.getBuckets(...) seems to return a Promise, not a Stream, and the it returns an Array of buckets instead of stream.

I'm guessing recent packages/common/src/stream-router.js needs to be rewritten to support recent changes to Promise patterns.

cc: @jmdobry

Activity

  1. callmehiphop commented on Oct 18, 2016

    @callmehiphop
    callmehiphop
    on Oct 18, 2016
    Contributor

    @jmuk we just released changes today that moved all streaming APIs to their own methods (in this case GCS.getBuckets() became GCS.getBucketsStream()). So what you're describing is actually the expected behavior.

    If you update to [email protected] the error you're describing should disappear.

  2. stephenplusplus
    added
    api: languageIssues related to the Cloud Natural Language API API.
    on Oct 18, 2016

  3. stephenplusplus commented on Oct 18, 2016

    @stephenplusplus
    stephenplusplus
    on Oct 18, 2016
    Contributor

    Yes, just rebase with master. The system tests depend on the latest release of @google-cloud/storage, which changed last night to promises.

  4. stephenplusplus
    closed this as completedon Oct 18, 2016
  5. JustinBeckwith
    assigned
    stephenplusplus
    on Feb 1, 2021
  6. miguelvelezsa
    added a commit that references this issue on Jul 23, 2025

    build: another attempt at making the release CI work (#1716)

    1fae5ea
  7. sofisl
    added a commit that references this issue on Feb 26, 2026

    test: use fully qualified request type name in tests (#1716)

    2ad9d4a
  8. GautamSharda
    added a commit that references this issue on Mar 11, 2026

    chore(main): release 3.5.1 (#1716)

    6363da3
  9. sofisl
    added 2 commits that reference this issue on Mar 17, 2026

    build: another attempt at making the release CI work (#1716)

    77345a6

    chore(deps): update dependency @types/node to v22 (#1716)

    c662e6c
  10. GautamSharda
    added 2 commits that reference this issue on Mar 23, 2026

    chore(main): release 6.4.1 (#1716)

    79c93ea

    chore(main): release 6.4.1 (#1716)

    7d85662
  11. feywind
    added a commit that references this issue on Mar 27, 2026

    chore(main): release 3.5.1 (#1716)

    f389ba7
  12. shivanee-p
    added a commit that references this issue on Mar 27, 2026

    chore(main): release 6.4.1 (#1716)

    64c443e
  13. thiyaguk09
    added a commit that references this issue on May 5, 2026

    chore(main): release 6.4.1 (googleapis#1716)

    1c1deb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: languageIssues related to the Cloud Natural Language API API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions