Skip to content

Google Cloud Speech NodeJS veneer: Examples in comments don't illustrate needed parameters #1926

Description

@pbogle

The examples in the comments in the NodeJS veneer won't work because they don't include needed parameters: e.g. the {} values in:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/packages/speech/src/v1beta1/speech_client.js#L158

 var client = speechV1beta1.speechClient();
  var config = {};
  var audio = {};
  var request = {
      config: config,
      audio: audio
  };
  client.syncRecognize(request).then(function(responses) {
      var response = responses[0];
      // doThingsWith(response)
  }).catch(function(err) {
      console.error(err);
  });


Activity

  1. angadn commented on Jan 19, 2017

    @angadn

    +1 This was a major problem for me while implementing Speech APIs also, and I resolved it by reading through source-code. It's typical for an early-stage BETA

  2. stephenplusplus commented on Jan 19, 2017

    @stephenplusplus
    Contributor
  3. jmuk commented on Jan 19, 2017

    @jmuk
    Contributor

    I see. This sample is auto-generated, and it missed to capture patterns like this. I've filed googleapis/gapic-generator#941

  4. self-assigned this
    on Jan 19, 2017
  5. stephenplusplus commented on Jan 19, 2017

    @stephenplusplus
    Contributor

    Thanks, @jmuk!

  6. added a commit that references this issue on Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: speechIssues related to the Speech-to-Text API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions