Skip to content

system test setup instructions out of date? #1982

Closed

Description

@ofrobots

From https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/.github/CONTRIBUTING.md:

$ gcloud preview datastore create-indexes system-test/data/index.yaml
  1. I think preview can be dropped now.
  2. I cannot find the file system-test/data/index.yaml. I am guessing that this isn't the same as ./packages/vision/system-test/data/index.yaml?

Activity

  1. stephenplusplus commented on Feb 10, 2017

    @stephenplusplus
    Contributor

    That file should actually be moved to the packages/datastore/system-test/data/ directory. It looks like it got misplaced when we modularized the repo. PR? :)

  2. ofrobots commented on Feb 10, 2017

    @ofrobots
    ContributorAuthor

    Sure. But even after running the create-indexes, I get the following error with the logging system tests:

      1) Logging sinks should create a sink with a Bucket destination:
         Uncaught Error: The caller does not have permission
          at node_modules/grpc/src/node/src/client.js:434:17
    

    I do have $GCLOUD_TESTS_PROJECT_ID and $GCLOUD_TESTS_KEY set to valid values.

  3. stephenplusplus commented on Feb 10, 2017

    @stephenplusplus
    Contributor

    I think the create indexes command will only relate to the Datastore tests.

    For the Logging test, that's a new issue. I can reproduce that as well. That used to happen for me when we were developing it, but it hasn't since. @callmehiphop can you see if you get that error?

  4. added
    type: questionRequest for information or clarification. Not an issue.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    type: questionRequest for information or clarification. Not an issue.
    on Feb 27, 2017
  5. removed
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

coretype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions