Skip to content

Documentation for Transaction.deleteRows() does not match behavior #2008

Closed
Closed
Documentation for Transaction.deleteRows() does not match behavior#2008
Assignees
stephenplusplus
Labels
api: spannerIssues related to the Spanner API.

Description

@modeswitch
modeswitch
opened on Feb 18, 2017

Docs claim that if a callback is omitted, a Promise is returned (see: https://googlecloudplatform.github.io/google-cloud-node/#/docs/spanner/0.1.0/spanner/transaction?method=deleteRows).

When invoked without a callback, nothing is returned. See: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/7ba12d080b499e5461ba51f9e08d559d6c41aaaa/packages/spanner/src/transaction-

Activity

  1. stephenplusplus
    added
    docs
    api: spannerIssues related to the Spanner API.
    on Feb 18, 2017

  2. stephenplusplus commented on Feb 18, 2017

    @stephenplusplus
    stephenplusplus
    on Feb 18, 2017
    Contributor

    Thanks for catching this and reporting. It looks like those docs could use a sweep, as transaction.deleteRows() doesn't do anything asynchronously, it just queues the delete request until transaction.commit() is called. I've sent #2009 with the fixes. Sorry for the confusion.

  3. stephenplusplus
    closed this as completedin #2009on Feb 21, 2017
  4. JustinBeckwith
    assigned
    stephenplusplus
    on Feb 1, 2021
  5. sofisl
    added a commit that references this issue on Feb 24, 2026

    chore(main): release 7.4.0 (#2008)

    f23408b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the Spanner API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions