Repository navigation
Spanner - transaction.runStream : fails for large query results : Uncaught TypeError: Cannot read property 'rowType' of null #2273
Description
Environment details
- OS: Mac OSX 10.12.4
- Node.js version: 6.7.0
- npm version: 3.10.8
- @google-cloud/spanner version: 0.4.2
Steps to reproduce
- require
@google-cloud/spanner - Run transaction.runStream on a large result set (~10k records)
collectionSelf.connection.runTransaction(function(err, transaction) {
if (err) {
var msg = `${name} : could not run transaction : ${JSON.stringify(err)}`;
log.error(msg);
log.error(err.stack);
reject(msg);
}
var results = [];
transaction.runStream(query)
.on('error', function(err) {
log.error(`${name} : runStream error : ${JSON.stringify(err)}`);
reject(err);
})
.on('data', function(row) {
log.silly(`${name} : runStream : ${JSON.stringify(row)}`);
results.push(row);
})
.on('end', function() {
log.debug(`${name} : runStream end`);
resolve(results);
});
});
- The following error happens
Uncaught TypeError: Cannot read property 'rowType' of null
at Function.partialResultStream.formatRow_ (node_modules/@google-cloud/spanner/src/partial-result-stream.js:167:28)
it seems that row.metadata is null in the response
As printing out row gives the following
{"values": [<very long array of objets>,"metadata":null,"chunkedValue":false,"resumeToken":[],"stats":null}]}
Are large result sets not supported even with runStream? Thanks
Activity
[-]Transaction.runStream : fails for large query results : Uncaught TypeError: Cannot read property 'rowType' of null[/-][+]Spanner - transaction.runStream : fails for large query results : Uncaught TypeError: Cannot read property 'rowType' of null[/+]stephenplusplus commentedon May 2, 2017
This is likely a bug in our code, thank you for reporting.
@callmehiphop in implementing the full set of tests in Spanner, has anything come up that would touch on this? 'metadata' is only present in the first response of a result set, so it would seem we are calling formatRow_ at an incorrect time.
callmehiphop commentedon May 8, 2017
@stephenplusplus this did come up, we just needed to cache the metadata from previous requests. This should be fixed/released by EOW
dominiksteiner commentedon May 16, 2017
Thanks for the update, was there any change on this last week?
stephenplusplus commentedon May 16, 2017
No change yet- the fix is in #2313.
dominiksteiner commentedon May 16, 2017
@stephenplusplus thanks for the update and for the fix
chore: do not run windows tests in the test-script environment (#2273)