Commit called if rollback fails

I believe I am reading the code correctly (please close this if I'm not!) -- based on the docs for transactions I should do something like this:

ds.runInTransaction(function(txn, done) {
  txn.get(key, function(err, entity) {
    if (err) {
      txn.rollback(done);
    }
  });
}, function(err) {});

However if the rollback fails, we'll call done without ever setting isFinalized = true. I believe this means we'll then try to commit the transaction, which doesn't seem like the desired outcome. It's ok to just not rollback the transaction, eventually it will expire, so rollback should always immediately set isFinalized = true.

Also I'm not sure if this gets fixed at all by the refactor that's currently happening with Transaction.

You're right. If the rollback fails, when Transaction.prototype.finalize gets called, it won't see that a rollback was attempted, and it will try to commit. Your suggested fix sounds good to me.

datastore: mark failed rollbacks as finalized