Skip to content

general: Investigate using square/protob #249

Description

@jgeewax

https://github.com/square/protob looks like it might be something worth investigating... Just figured I'd mention that here so we don't lose track of it.

Activity

  1. ryanseys commented on Oct 5, 2014

    @ryanseys
    Contributor

    @beriberikix mentioned this when it was released. @rakyll said it was a mess for default values but otherwise was doing the right thing. I'm cool with keeping this open and potentially opening an issue to discuss our complaints. Would be nice to use a corporate-backed solution that can support us.

  2. ryanseys commented on Jan 20, 2015

    @ryanseys
    Contributor

    I don't think this protob has really taken off as a library and doesn't seem to be a very active or open project (no ci integration, no issues opened or closed, no PRs). I think the performance we get from Protobuf.js is good (and protob uses code from the library anyway). I don't think we will need to port our code to another protobuf library anytime soon and if we REALLY need to in the future, I have faith we will find the right solution in due time, so I'm closing this issue. Feel free to open if you think we might benefit from a better protobuf library or otherwise think we should continue to investigate it further.

  3. modified the milestone: Core Stable on Feb 2, 2015
  4. added a commit that references this issue on Sep 16, 2022
  5. 39 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions