Skip to content

bigquery: table#insertHandler() document is wrong #336

Description

@hakobera

In table#insertHander(err, insertErrors) document, insertErrors[] has errors property.

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/bigquery/table.js#L727-L728

But actually it has error not errors.

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/bigquery/table.js#L755

Which is correct spec? document or implementation?

Activity

  1. stephenplusplus commented on Dec 22, 2014

    @stephenplusplus
    Contributor

    It should be errors in the code. Sorry for the mix-up!

  2. added 2 commits that reference this issue on Dec 22, 2014
    be2a2ec
    fb46ca1
  3. added a commit that references this issue on Dec 22, 2014
    77a0645
  4. added
    api: bigqueryIssues related to the BigQuery API.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Feb 2, 2015
  5. 42 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🚨This issue needs some love.api: bigqueryIssues related to the BigQuery API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions