Skip to content

Final review for PubSub by Google PubSub team #487

Description

@ryanseys

Should we have this reviewed more?

Activity

  1. pierre-b commented on May 1, 2015

    @pierre-b

    Yes, the doc is quite a mess actually, looking at the code is essential.

    Could you please update the doc, the message.id should be message.ackId https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.13.2/pubsub/subscription?method=ack

    Thank you

  2. changed the title [-]Final review for PubSub[/-] [+]Final review for PubSub by Google PubSub team[/+] on May 1, 2015
  3. added this to the Pub/Sub Stable milestone on May 1, 2015
  4. ryanseys commented on May 3, 2015

    @ryanseys
    ContributorAuthor

    @pierre-b Hi thanks for your concerns. Is there any other specific issues you would like us to address?

  5. pierre-b commented on May 4, 2015

    @pierre-b

    Hi @ryanseys , I noticed a 30sec average lag when I open a subscription and the first message arrives, then the others arrive directly. Is this an expected behavior ?

    I also need to know how many messages are waiting in the subscription, to pop new workers or monitor the health of my system. Is it in the roadmap actually ?

    Thank you

  6. jgeewax commented on May 4, 2015

    @jgeewax
    Contributor

    Hi @pierre-b: Can you put these in separate issues so we can track them individually?

  7. tmatsuo commented on May 12, 2015

    @tmatsuo
    Contributor

    I will look at the code this week.

  8. pierre-b commented on May 12, 2015

    @pierre-b

    Hi @jgeewax , forgot to tell you Ive opened separate issues.

  9. tmatsuo commented on May 16, 2015

    @tmatsuo
    Contributor

    Pubsub holds the project id, which prevents you from accessing resources in multiple projects.

    https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/pubsub/index.js#L90

    Is this expected?

  10. jgeewax commented on May 16, 2015

    @jgeewax
    Contributor

    Just to be clear, it seems to me that I could do:

    var gcloud = require('gcloud');
    var pubsub1 = gcloud.pubsub({projectId: 'project1'});
    var pubsub2 = gcloud.pubsub({projectId: 'project2'});

    right?

    This would allow us to access resources across projects, no?

  11. tmatsuo commented on May 16, 2015

    @tmatsuo
    Contributor

    @jgeewax I hope you're right. I meant you can not access multiple projects unless creating multiple pubsub object.

    However, I came up with a bad scenario.
    I have 2 projects; project1 and project2.
    I have 1 topic; topic1 in project1.
    I have 1 subscription; subscription2 in project2, which subscribes to the topic1.

    I don't think I can access to the subscription2 easily. It seems to me that the only way is to call pubsub.getSubscriptions() and iterate like:

    var pubsub2 = gcloud.pubsub({projectId: 'project2'});
    pubsub2.getSubscriptions(
      func(err, subscriptions, nextQuery, apiResponse) {
        // I don't come up with how to iterate the result easily
      }
    )

    Since if I do the following, the subscription object will have a wrong projectId:

    var pubsub1 = gcloud.pubsub({projectId: 'project1'});
    var topic1 = pubsub1.topic('topic1');
    var sub2 = topic1.subscription('subscription2'); // sub2 will have 'project1', which is wrong
  12. 36 remaining items

  13. added a commit that references this issue on Mar 5, 2026
  14. added a commit that references this issue on Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: pubsubIssues related to the Pub/Sub API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions