Skip to content

Where is the code for Dataset.get() ...? #537

Description

@jgeewax

If I go to http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/dataset?method=get

And click the "view code" link (https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/dataset.js#L102) I'm taken to an empty line...

Looking around in the file didn't send me to any code...

Is this method magically injected somehow?

Activity

  1. added
    type: questionRequest for information or clarification. Not an issue.
    api: datastoreIssues related to the Datastore API.
    on May 7, 2015
  2. added this to the Datastore Stable milestone on May 7, 2015
  3. stephenplusplus commented on May 7, 2015

    @stephenplusplus
    Contributor

    Oh man, the complicated web that is JSDocs + the Docs -> MD tool we use + how we rig things up on the FE. A Dataset has a @­mixin of the Transaction class, which is where get comes from. http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/transaction?method=get

    Off the top of my head, I can't think of an easy way to solve for this, but will think on it.

  4. jgeewax commented on May 7, 2015

    @jgeewax
    ContributorAuthor
  5. stephenplusplus commented on May 7, 2015

    @stephenplusplus
    Contributor

    Oops, the web gets webbier. Transaction itself has a @­mixin on the DatastoreRequest class, which is finally where get lives: https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/request.js#L102

  6. ryanseys commented on May 7, 2015

    @ryanseys
    Contributor

    So it got the line number right, but the file wrong. I don't know if that helps make things any easier?

  7. stephenplusplus commented on May 8, 2015

    @stephenplusplus
    Contributor

    That does, indeed. Let's see what we can do about this...

  8. stephenplusplus commented on May 14, 2015

    @stephenplusplus
    Contributor

    This was resolved by #584 - I tagged the wrong issue in the PR.

  9. 13 remaining items

  10. added a commit that references this issue on Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: datastoreIssues related to the Datastore API.type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions