Skip to content

BigQuery job body included in many requests that don't need it #647

Closed
Closed
BigQuery job body included in many requests that don't need it#647
Assignees
stephenplusplus
Labels
api: bigqueryIssues related to the BigQuery API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@ryanseys
ryanseys
opened on Jun 8, 2015

Filed internally at b/21557935, moving to public here:

Ryan, looking at some of our API logs for an unrelated issue, I see gcloud-node is including a giant query string of an entire job configuration for BigQuery API methods that do not require it, such as getQueryResults(). Is there any reason for this? Looking at the gcloud-node code, it seems like simply removing it from all the GET call request options should greatly reduce request size.

I'm guessing the issue starts here.

Activity

  1. stephenplusplus
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    api: bigqueryIssues related to the BigQuery API.
    on Jun 8, 2015

  2. stephenplusplus commented on Jun 8, 2015

    @stephenplusplus
    stephenplusplus
    on Jun 8, 2015
    Contributor

    Thanks for posting here!

    We will just need to filter what we pass to the API, example: https://github.com/GoogleCloudPlatform/gcloud-node/blob/01ec51f5b37becccdc20130c6389e8201cc1f389/lib/bigquery/index.js#L374

  3. weslem commented on Jun 9, 2015

    @weslem
    weslem
    on Jun 9, 2015

    Your linked code is exactly what confused me to write the bug. The call to makeReq_() for an existing query passes the entire options as a query string, substantially growing the size of the request. I think you can just null out the query string instead, but I'm concerned I've missed some important context.

  4. stephenplusplus
    self-assigned this
    on Jun 10, 2015

  5. stephenplusplus commented on Jun 10, 2015

    @stephenplusplus
    stephenplusplus
    on Jun 10, 2015
    Contributor

    @weslem I sent #652 to fix the issue with getQueryResults. Which other API calls did you find that were passing the object?

  6. weslem commented on Jun 10, 2015

    @weslem
    weslem
    on Jun 10, 2015

    #652 LGTM; that was the only place I found.

  7. stephenplusplus commented on Jun 10, 2015

    @stephenplusplus
    stephenplusplus
    on Jun 10, 2015
    Contributor

    Awesome, thanks for catching this bug for us! I'm going to create an issue to make sure we plug any leaks that may exist in our other methods.

    Oh, and feel free to report right to us here on the repo next time :)

  8. stephenplusplus
    closed this as completedin #652on Jun 10, 2015
  9. sofisl
    added 2 commits that reference this issue on Oct 11, 2022

    chore(deps): update dependency sinon to v13 (#647)

    ed80de2

    chore(deps): update dependency sinon to v13 (#647)

    e9fc909
  10. sofisl
    added 2 commits that reference this issue on Nov 10, 2022

    chore: migrate to owl bot (#647)

    0b92bcd

    fix(deps): use google-gax v3.5.2 (#647)

    c70cfd7
  11. sofisl
    added a commit that references this issue on Jan 10, 2023

    chore: release 3.2.0 (#647)

    5f322d0
  12. sofisl
    added a commit that references this issue on Jan 24, 2023

    chore: release 4.1.3 (#647)

    1044b55

  13. 17 remaining items

  14. GautamSharda
    added a commit that references this issue on Feb 3, 2026

    Enable staleness and pull request size bots on repository (#647)

    c43af2e
  15. sofisl
    added 2 commits that reference this issue on Feb 4, 2026

    migrate code from googleapis/cloud-profiler-nodejs (#7087)

    288deb4

    chore(deps): update dependency cpy-cli to v4 (#647)

    0103236
  16. GautamSharda
    added a commit that references this issue on Feb 5, 2026

    build(node): add new jsteam + enforce branches up-to-date (#1451) (#647)

    cb02d6d
  17. GautamSharda
    added 3 commits that reference this issue on Feb 23, 2026

    build(node): add new jsteam + enforce branches up-to-date (#1451) (#647)

    c69c797

    test: Skip test where large request returns an error (#647)

    991b335

    build(node): add new jsteam + enforce branches up-to-date (#1451) (#647)

    f54d233
  18. sofisl
    added a commit that references this issue on Feb 26, 2026

    fix(docs): move to new client docs URL (#647)

    fa0f5bf
  19. GautamSharda
    added a commit that references this issue on Mar 11, 2026

    feat: support apiEndpoint override (#647)

    0ae6125
  20. sofisl
    added a commit that references this issue on Mar 17, 2026

    chore(deps): update dependency @types/multiparty to v4 (#647)

    874bac1
  21. thiyaguk09
    added a commit that references this issue on Mar 18, 2026

    docs(samples): refactor the quickstart to match the new rubric (googl…

    e110276
  22. GautamSharda
    added 2 commits that reference this issue on Mar 23, 2026

    docs: mention templates in contributing section of README (#647)

    43e78ac

    docs: mention templates in contributing section of README (#647)

    c924455
  23. shivanee-p
    added a commit that references this issue on Mar 27, 2026

    docs: mention templates in contributing section of README (#647)

    4a0deb7
  24. thiyaguk09
    added a commit that references this issue on May 5, 2026

    docs: mention templates in contributing section of README (googleapis…

    287a414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigqueryIssues related to the BigQuery API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions