Skip to content

Is the Datastore Query object supposed to be immutable? #731

Closed
Closed
Is the Datastore Query object supposed to be immutable?#731
Assignees
callmehiphop
Labels
api: datastoreIssues related to the Datastore API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@callmehiphop
callmehiphop
opened on Jul 20, 2015

At first glance I assumed that the Query class was supposed to be immutable -- each method creates a new query instance, copies all of the properties from the previous instance and then returns it.

However, I noticed that for methods that can be called multiple times (filter() and order()) it holds a reference to the previous instance.

e.g.

var query1 = new Query(['kind1']);
var query2 = query1.filter('count >', 5);

query1.filters.length; // => 1

Is this the desired functionality?

Activity

  1. callmehiphop
    added
    type: questionRequest for information or clarification. Not an issue.
    api: datastoreIssues related to the Datastore API.
    on Jul 20, 2015

  2. stephenplusplus commented on Jul 20, 2015

    @stephenplusplus
    stephenplusplus
    on Jul 20, 2015
    Contributor

    No! If you have a chance to write those methods better, please do!

  3. callmehiphop
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    type: questionRequest for information or clarification. Not an issue.
    on Jul 20, 2015
  4. callmehiphop
    self-assigned this
    on Jul 20, 2015
  5. stephenplusplus
    closed this as completedin #732on Jul 21, 2015
  6. sofisl
    added a commit that references this issue on Nov 17, 2022

    chore(main): release 3.3.0 (#731)

    67eec11
  7. miguelvelezsa
    added a commit that references this issue on Jul 23, 2025

    chore: release 1.14.2 (#731)

    fa2d906
  8. GautamSharda
    added 3 commits that reference this issue on Jan 14, 2026

    chore(main): release 5.1.3 (#731)

    d4b62f0

    chore(main): release 5.1.3 (#731)

    615147d

    chore(main): release 5.1.3 (#731)

    55d622d
  9. sofisl
    added 3 commits that reference this issue on Jan 27, 2026

    fix(deps): update dependency pprof to v3.1.0 (#731)

    378b095

    chore: release 4.1.2 (#734)

    9639e72

    fix(deps): update dependency pprof to v3.1.0 (#731)

    758a3e5

  10. 11 remaining items

  11. sofisl
    added 3 commits that reference this issue on Jan 29, 2026

    chore: release 4.1.2 (#734)

    77a55af

    fix(deps): update dependency pprof to v3.1.0 (#731)

    a09669c

    chore: release 4.1.2 (#734)

    b486fda
  12. GautamSharda
    added 2 commits that reference this issue on Feb 2, 2026

    chore(main): release 5.1.3 (#731)

    960f85a

    chore(main): release 5.1.3 (#731)

    8ea9b93
  13. sofisl
    added 2 commits that reference this issue on Feb 4, 2026

    migrate code from googleapis/cloud-profiler-nodejs (#7087)

    288deb4

    docs: direct to documentation for datastore, not the product landing …

    ffcbc03
  14. GautamSharda
    added a commit that references this issue on Feb 5, 2026

    chore: update cloud-rad version to ^0.4.0 (#731)

    c76af71
  15. sofisl
    added a commit that references this issue on Feb 17, 2026

    docs: direct to documentation for datastore, not the product landing …

    779530b
  16. GautamSharda
    added a commit that references this issue on Feb 23, 2026

    chore: update cloud-rad version to ^0.4.0 (#731)

    d60ebbc
  17. sofisl
    added a commit that references this issue on Feb 24, 2026

    chore: release 2.2.7 (#731)

    c093e08
  18. GautamSharda
    added a commit that references this issue on Feb 26, 2026

    chore: update cloud-rad version to ^0.4.0 (#731)

    d155560
  19. sofisl
    added a commit that references this issue on Feb 26, 2026

    fix(docs): snippets are now replaced in jsdoc comments (#731)

    b907efa
  20. GautamSharda
    added 2 commits that reference this issue on Mar 5, 2026

    build(test): adds support for build cop, fixes codecov.io (#731)

    97a8603

    fix: pull projectId from auth client with emulator (#731)

    24f6ca2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the Datastore API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions