Skip to content

[BUG] Sometimes, Key element in Datastore is parsed as id  #874

Closed
Closed
[BUG] Sometimes, Key element in Datastore is parsed as id #874
Assignees
yoshi-automation
Labels
api: datastoreIssues related to the Datastore API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@dg3feiko
dg3feiko
opened on Sep 20, 2015

Env

Node: 2.3.3
gcloud: 0.21.0

Problem

dataset.key(['Tracking2', "556ba07cbeb676ba7e9458e8"]) => key path: name =556ba07cbeb676ba7e9458e8
but
dataset.key(['Tracking2', "55479506996815820615e988"]) => key path: id=-9204792730274402000

Root cause

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/datastore/entity.js#L227

> isNaN("556ba07cbeb676ba7e9458e8")
true
> isNaN("55479506996815820615e988")
false

explain: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/isNaN#Description

Activity

  1. jgeewax commented on Sep 20, 2015

    @jgeewax
    jgeewax
    on Sep 20, 2015 via email
    Contributor

  2. stephenplusplus commented on Sep 20, 2015

    @stephenplusplus
    stephenplusplus
    on Sep 20, 2015
    Contributor

    Very nice! A PR is welcome to use is.number instead, otherwise someone will jump on this soon. Thanks for reporting!

  3. stephenplusplus
    added
    api: datastoreIssues related to the Datastore API.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Sep 20, 2015
  4. callmehiphop
    closed this as completedin #880on Sep 21, 2015
  5. JustinBeckwith
    assigned
    yoshi-automation
    on Feb 1, 2021
  6. sofisl
    added a commit that references this issue on Nov 11, 2022

    chore: relocate owl bot post processor (#874)

    72f7b71
  7. sofisl
    added 2 commits that reference this issue on Jan 24, 2023

    build(node): update client library version in samples metadata (#1356) (

    172e741

    build(node): update client library version in samples metadata (#1356) (

    42be35d
  8. sofisl
    added 6 commits that reference this issue on Jan 27, 2026

    chore: fix broken build and tests (#874)

    6828940

    chore: fix broken build and tests (#874)

    1961b7e

    chore: fix broken build and tests (#874)

    eb7c027

    chore: fix broken build and tests (#874)

    8e2dcfb

    chore: fix broken build and tests (#874)

    81a59a8

    chore: fix broken build and tests (#874)

    2cfbaea

  9. 1 remaining item

  10. sofisl
    added 3 commits that reference this issue on Jan 29, 2026

    chore: fix broken build and tests (#874)

    285679e

    chore: fix broken build and tests (#874)

    5108175

    chore: relocate owl bot post processor (#874)

    a50a224
  11. sofisl
    added a commit that references this issue on Feb 17, 2026

    chore: relocate owl bot post processor (#874)

    601080e
  12. sofisl
    added 2 commits that reference this issue on Feb 24, 2026

    fix: don't format log message if logging is disable (#874)

    66a9ac9

    fix: file#move do not delete origin file if same as destination (#874)

    b83bce8
  13. GautamSharda
    added a commit that references this issue on Mar 5, 2026

    chore: start tracking obsolete files (#874)

    b4e331c
  14. sofisl
    added a commit that references this issue on Mar 5, 2026

    Merge pull request #874 from googleapis/release-please--branches--main

    68bc4d8
  15. GautamSharda
    added a commit that references this issue on Mar 11, 2026

    chore: release 1.5.0 (#874)

    be4770b
  16. thiyaguk09
    added a commit that references this issue on Mar 18, 2026

    fix: file#move do not delete origin file if same as destination (goog…

    8e4a905
  17. GautamSharda
    added 2 commits that reference this issue on Mar 23, 2026

    chore: release 3.5.1 (#874)

    52d93fa

    chore: release 3.5.1 (#874)

    6e3f99e
  18. feywind
    added a commit that references this issue on Mar 27, 2026

    chore: release 1.5.0 (#874)

    092578a
  19. shivanee-p
    added a commit that references this issue on Mar 27, 2026

    chore: release 3.5.1 (#874)

    6e04822
  20. thiyaguk09
    added a commit that references this issue on May 5, 2026

    chore: release 3.5.1 (googleapis#874)

    ba7fc52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the Datastore API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions