Skip to content

pubsub: reused subscriptions should not rely on API response for data #997

Description

@stephenplusplus

at line 471 in pubsub/index.js you should use resp.name || subName (if the status is 409 and reuseExisting is true i got The name of a subscription is required. error).

Reported by @leibale.

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    api: pubsubIssues related to the Pub/Sub API.
    on Dec 6, 2015
  2. changed the title [-]you should use resp.name || subName (if the status is 409 and reuseExisting is true i got The name of a subscription is required. error).[/-] [+]pubsub: reused subscriptions should not rely on API response for data[/+] on Dec 6, 2015
  3. leibale commented on Dec 7, 2015

    @leibale
    Contributor

    ??

  4. stephenplusplus commented on Dec 7, 2015

    @stephenplusplus
    ContributorAuthor

    @leibale This was fixed and merged in #999.

  5. leibale commented on Dec 7, 2015

    @leibale
    Contributor

    sorry, i didn't see it the phone.
    thanks :)

  6. added a commit that references this issue on Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: pubsubIssues related to the Pub/Sub API.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions