Skip to content

[PR] Update README for more clarity - #1446

Merged
stephenplusplus merged 2 commits into
googleapis:masterfrom
commit-master:master
Jul 22, 2016
Merged

[PR] Update README for more clarity#1446
stephenplusplus merged 2 commits into
googleapis:masterfrom
commit-master:master

Conversation

@commit-master

@commit-master commit-master commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Added in comment the other option using credentials instead of keyFilename.
Also added comments to explain the difference between both.

@googlebot

googlebot commented Jul 22, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2016
@commit-master

commit-master commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

googlebot commented Jul 22, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2016
@coveralls

coveralls commented Jul 22, 2016 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 3cbcfe4 on commit-master:master into 5689f96 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Jul 22, 2016
View reviewed changes
Comment thread README.md Outdated
var gcloud = require('gcloud')({
projectId: projectId,
keyFilename: '/path/to/keyfile.json'
});

This comment was marked as spam.

Sign in to view

@stephenplusplus

stephenplusplus commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Thanks :D

@commit-master

commit-master commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

This is my first PR actually ahah. Sounds very good to me ! Way more clear than my attempt.

Thanks !

@stephenplusplus

stephenplusplus commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Oh that's awesome, thanks for spending it on helping us! I remember my first PR... ah, the good ol' days.

Hey, now you can change your name to pr-master :)

@commit-master

commit-master commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

Ahaha thanks ! Appreciate it !
💥 ⚡️ 🎉

@coveralls

coveralls commented Jul 22, 2016 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 532f980 on commit-master:master into 5689f96 on GoogleCloudPlatform:master.

@stephenplusplus

stephenplusplus commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Looks great to me. Thanks again, feel free to send us many more :)

@stephenplusplus
stephenplusplus merged commit 86e5fd8 into googleapis:master Jul 22, 2016
@commit-master

commit-master commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

Thank you, I feel complete now 🎆

@stephenplusplus

stephenplusplus commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Hahaha 🌠 💯 🏁

sofisl pushed a commit that referenced this pull request Feb 24, 2026
@release-please
chore: release 4.9.7 (#1446)
67f9e35 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.9.7](https://www.github.com/googleapis/nodejs-firestore/compare/v4.9.6...v4.9.7) (2021-03-09)


### Bug Fixes

* export v1 and v1beta1 client class types correctly ([#1445](https://www.github.com/googleapis/nodejs-firestore/issues/1445)) ([6c9319e](https://www.github.com/googleapis/nodejs-firestore/commit/6c9319ed6e2ac0dfe0fcf45853f0b38dc0784686))
* retry BulkWriter deletes that fail with RST_STREAM error ([#1442](https://www.github.com/googleapis/nodejs-firestore/issues/1442)) ([cccf48d](https://www.github.com/googleapis/nodejs-firestore/commit/cccf48de4963403a2e77ba241641a2b77fb993da))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda pushed a commit that referenced this pull request Mar 5, 2026
@renovate-bot @sofisl
chore(deps): update dependency jsdoc-region-tag to v3 (#1446)
2229997 
Co-authored-by: sofisl <[email protected]>
GautamSharda pushed a commit that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 5.1.1 (#1446)
8157217 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
GautamSharda pushed a commit that referenced this pull request Mar 25, 2026
@release-please @GautamSharda
chore(main): release 5.1.1 (#1446)
284a4c3 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
shivanee-p pushed a commit that referenced this pull request Mar 27, 2026
@release-please @shivanee-p
chore(main): release 5.1.1 (#1446)
09f5f79 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request May 5, 2026
@release-please @thiyaguk09
chore(main): release 5.1.1 (googleapis#1446)
2e269bb 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@commit-master @googlebot @coveralls @stephenplusplus