Repository navigation
google-cloud: use npm shrinkwrap - #1632
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
I think we're going to want to work this into our publish script? |
Contributor
Author
|
@callmehiphop PTAL. Also confirm this will fix the 3 issues tagged in the OP, or if there's more to do. |
| if (moduleName === 'google-cloud') { | ||
| if (npmVersion < 3) { | ||
| throw new Error([ | ||
| 'Publishing google-cloud requires the latest npm.' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
…ing the REST fallback (#1632) * fix: Disable pretty-print for JSON reponses when using the REST fallback * Investigating CI issue with failing numeric enum tests. * Fix failing CI tests. * Additional test fixes. * Add opt-in setting minifyJson and tests. * Tweaks for code review comments. * More cleanup. --------- Co-authored-by: Daniel Bankhead <[email protected]> Co-authored-by: sofisl <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
* fix: updated connection reset string * updated test
sofisl
pushed a commit
that referenced
this pull request
Mar 17, 2026
sofisl
added a commit
that referenced
this pull request
Mar 17, 2026
…ing the REST fallback (#1632) * fix: Disable pretty-print for JSON reponses when using the REST fallback * Investigating CI issue with failing numeric enum tests. * Fix failing CI tests. * Additional test fixes. * Add opt-in setting minifyJson and tests. * Tweaks for code review comments. * More cleanup. --------- Co-authored-by: Daniel Bankhead <[email protected]> Co-authored-by: sofisl <[email protected]>
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
Mar 18, 2026
* fix: updated connection reset string * updated test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1590
Fixes #1605
Fixes #1627
@callmehiphop's idea.