Repository navigation
Regenerate speech API. Now it contains streamingRecognize method. - #1775
Conversation
This does not change src/index.js yet.
|
I've tried to integrate this with src/index, and it seems to work, except for the speech.createRecognizeStream({...})
.on('response', function(response) {
response === {
"code": 200,
"details": "",
"metadata": {
"_internal_repr": {
"content-disposition": [
"attachment"
]
}
},
"message": "OK"
}
})
.on('data', function() {...}) |
|
@jmuk to clarify, this We rename it to |
|
I see. It seems gax loses |
|
Could it be |
|
Maybe, what is the difference between the status and response objects? |
|
|
|
@callmehiphop wdyt? I think you were more closely connected with our implementation. |
|
I think something to note is that status and metadata occur at different times. Where metadata happens once the request starts, status doesn't happen until after all results have been processed. For that reason alone, I think in the veneer layer we typically listen for metadata. |
|
Ah, okay. So https://github.com/GoogleCloudPlatform/google-cloud-node/blob/116436fa789d8b0f7fc5100b19b424e3ec63e6bf/packages/common/src/grpc-service.js#L355 does take 'metadata' event, and create the response object with "code: 0" (i.e. succeeds). I'll do the same thing. |
|
Now it's added. |
|
I added a commit to use the new streaming method from our API. @callmehiphop could you take a look and push a commit that gets rid of anything we don't need, re: GrpcService? |
|
@stephenplusplus I don't think you can cut out |
|
Okay, thanks for taking a look. |
Co-authored-by: sofisl <[email protected]>
* test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: longrunning protos are no longer needed for v1 and v1beta1 clients Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <[email protected]>
Where the STRUCT value is an array, always determine inner member value using field index. STRUCT value is represented by var 'decoded'. Refs: #1774
Co-authored-by: sofisl <[email protected]>
This does not change src/index.js yet.