Skip to content

chore: re-consolidate eslint rules - #8458

Merged
jskeet merged 2 commits into
googleapis:mainfrom
quirogas:feat-remove-eslint
Jun 9, 2026
Merged

jskeet merged 2 commits into
googleapis:mainfrom
quirogas:feat-remove-eslint

Conversation

@quirogas

@quirogas quirogas commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Remove all ESLint files that were reintroduced by the old generator. All ESLint files were previously deleted from the packages directory in #8155; however, due to a misalignment between their deletion and the generator update, some of them were reintroduced.

@quirogas quirogas self-assigned this Jun 9, 2026
@quirogas
quirogas marked this pull request as ready for review June 9, 2026 07:17
@quirogas
quirogas requested a review from a team as a code owner June 9, 2026 07:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes numerous ESLint configuration files, including .eslintrc.json, .eslintrc.yml, and .eslintignore, across various directories in the codebase. This indicates a cleanup or centralization of the project's linting configuration. There are no review comments to evaluate, and I have no further feedback to provide.

@quirogas quirogas mentioned this pull request Jun 9, 2026
@jskeet
jskeet merged commit e5c687a into googleapis:main Jun 9, 2026
32 checks passed
bshaffer added a commit that referenced this pull request Sep 23, 2026
Split the override's rules into the pre-#8458 restoration (promise/*) and
the new relaxation (no-floating-promises, prefer-const), with TODO(#9432)
for the latter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants