Repository navigation
fix(ci): restore pnpm 7 in generation-check workflow - #9326
Merged
danieljbruce merged 2 commits intoSep 14, 2026
Merged
Conversation
Restore 'version: ^7.0.0' for the 'Setup pnpm' step in generation_check.yaml. PR googleapis#8973 removed this pinning when migrating the monorepo to pnpm 10. However, 'librarian install' compiles gapic-generator-typescript from gapic-generator-v5.2.0.tar.gz which contains a pnpm 7 lockfile. When pnpm 10 executes with '--frozen-lockfile' against that lockfile, it fails with ERR_PNPM_LOCKFILE_BREAKING_CHANGE. Fixes googleapis#9322
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
danieljbruce
approved these changes
Sep 14, 2026
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
Sep 15, 2026
Restore 'version: ^7.0.0' for the 'Setup pnpm' step in generation_check.yaml. PR googleapis#8973 removed this pinning when migrating the monorepo to pnpm 10. However, 'librarian install' compiles gapic-generator-typescript from gapic-generator-v5.2.0.tar.gz which contains a pnpm 7 lockfile. When pnpm 10 executes with '--frozen-lockfile' against that lockfile, it fails with ERR_PNPM_LOCKFILE_BREAKING_CHANGE. `librarian install` only support pnpm 7 at the moment. Fixes googleapis#9322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore 'version: ^7.0.0' for the 'Setup pnpm' step in generation_check.yaml.
PR #8973 removed this pinning when migrating the monorepo to pnpm 10. However, 'librarian install' compiles gapic-generator-typescript from gapic-generator-v5.2.0.tar.gz which contains a pnpm 7 lockfile. When pnpm 10 executes with '--frozen-lockfile' against that lockfile, it fails with ERR_PNPM_LOCKFILE_BREAKING_CHANGE.
librarian installonly support pnpm 7 at the moment.Fixes #9322