Repository navigation
fix(retry-request): move teeny-request to devDependencies - #9500
Merged
quirogas merged 2 commits intoOct 2, 2026
Merged
Conversation
retry-request never requires teeny-request at runtime. Callers must pass
their own `request` function via `opts.request`, and index.js throws if
they don't. The only non-test reference was a type in index.d.ts:
import * as teenyRequest from 'teeny-request';
type teenyRequestFunction =
typeof teenyRequest extends Function ? typeof teenyRequest : never;
teeny-request uses a named export, so `typeof teenyRequest` is the module
namespace and this type always resolves to `never`. Removing it leaves
`Options['request']` exactly as before (`typeof request`).
Moving teeny-request to devDependencies cuts a production install of
retry-request from 16 packages (9.7 MB) to 2 (88 KB), removing
node-fetch, the proxy agents, and polyfills for every google-gax
consumer, since google-gax depends on retry-request but never uses
teeny-request.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the 'teeny-request' dependency from the production dependencies of 'retry-request', moving it to 'devDependencies'. Consequently, the TypeScript type definitions in 'index.d.ts' have been updated to remove references to 'teeny-request' and its associated types, restricting the 'request' option to only accept 'typeof request'. There are no review comments, so I have no feedback to provide.
quirogas
reviewed
Oct 2, 2026
quirogas
approved these changes
Oct 2, 2026
quirogas
left a comment
quirogas
left a comment
Contributor
There was a problem hiding this comment.
Thank you! I have to go over a few things before merging, but LGTM!
Add license header Co-authored-by: Santiago Quiroga <[email protected]>
shivanee-p
approved these changes
Oct 2, 2026
quirogas
enabled auto-merge (squash)
October 2, 2026 20:14
Merged
shivanee-p
pushed a commit
that referenced
this pull request
Oct 5, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>google-gax: 6.11.0</summary> ## [6.11.0](google-gax-v6.10.0...google-gax-v6.11.0) (2026-10-03) ### Features * **gax:** Emit T4 attempt spans ([#9496](#9496)) ([51aedce](51aedce)) ### Bug Fixes * **gax:** Propagate chunk granularity on resume and preserve retry error details ([#9480](#9480)) ([02b9478](02b9478)) </details> <details><summary>retry-request: 9.0.2</summary> ## [9.0.2](retry-request-v9.0.1...retry-request-v9.0.2) (2026-10-03) ### Bug Fixes * **retry-request:** Move teeny-request to devDependencies ([#9500](#9500)) ([068fe52](068fe52)) </details> <details><summary>test-utils: 0.2.0</summary> ## [0.2.0](test-utils-v0.1.0...test-utils-v0.2.0) (2026-10-03) ### Features * **test-utils:** Add runtime detection predicates and cross-engine assertion helpers ([#9492](#9492)) ([f971bb5](f971bb5)) </details> <details><summary>chat: 0.34.0</summary> ## [0.34.0](chat-v0.33.1...chat-v0.34.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) </details> <details><summary>aiplatform: 7.5.0</summary> ## [7.5.0](aiplatform-v7.4.1...aiplatform-v7.5.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) </details> <details><summary>bigtable-api: 0.10.0</summary> ## [0.10.0](bigtable-api-v0.9.0...bigtable-api-v0.10.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9427](#9427)) ([5cd945d](5cd945d)) * Update API sources and regenerate ([#9472](#9472)) ([514e2f6](514e2f6)) </details> <details><summary>procurement: 0.10.0</summary> ## [0.10.0](procurement-v0.9.1...procurement-v0.10.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) </details> <details><summary>commerceproducer: 0.6.0</summary> ## [0.6.0](commerceproducer-v0.5.0...commerceproducer-v0.6.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) </details> <details><summary>compute: 7.7.0</summary> ## [7.7.0](compute-v7.6.0...compute-v7.7.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) * Update Compute v1 API to version 2026-09-01 ([#9503](#9503)) ([02e3361](02e3361)) ### Bug Fixes * All AggregatedList RPCs behavior is now return_partial_success=true ([02e3361](02e3361)) * All AggregatedList RPCs return_partial_success fields removed ([02e3361](02e3361)) </details> <details><summary>products: 0.12.0</summary> ## [0.12.0](products-v0.11.1...products-v0.12.0) (2026-10-03) ### Features * Update API sources and regenerate ([#9481](#9481)) ([35a2b9a](35a2b9a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/googleapis/teeny-request has been deprecated 2 years ago. retry-request never requires teeny-request at runtime. Callers must pass their own
requestfunction viaopts.request, and index.js throws if they don't. The only non-test reference was a type in index.d.ts:teeny-request uses a named export, so
typeof teenyRequestis the module namespace and this type always resolves tonever. Removing it leavesOptions['request']exactly as before (typeof request).Moving teeny-request to devDependencies cuts a production install of retry-request from 16 packages (9.7 MB) to 2 (88 KB), removing node-fetch, the proxy agents, and polyfills for every google-gax consumer, since google-gax depends on retry-request but never uses teeny-request.
Fixes #9010