Repository navigation
chore(test-utils): revert making google-test-utils a private workspace package - #9548
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes the core/test-utils package public, registers it in the release-please configuration, and updates its usage in the pubsub and spanner packages. Feedback points out that the dependency version for google-test-utils in both packages should be updated to workspace:^0.2.0 to match the workspace version and prevent installation failures. Additionally, the Cloud Build filters for spanner should be updated to use the prefix-only syntax ...{./handwritten/spanner} to avoid building unnecessary downstream dependents.
shivanee-p
changed the title
shivanee-p
force-pushed
the
shivaneep-revert-test-utils
branch
from
October 6, 2026 22:51
a9cfe58 to
afee093
Compare
shivanee-p
marked this pull request as ready for review
October 6, 2026 22:51
quirogas
approved these changes
Oct 6, 2026
quirogas
left a comment
quirogas
left a comment
Contributor
There was a problem hiding this comment.
LGTM as long as tests pass.
shivanee-p
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9525 (
be25b6fa1a6c6c90337ecad8afdcbcaeb477ded2) to keepgoogle-test-utils(core/test-utils) as a published package managed by Release Please, and updates consumer packages to depend on the published^0.2.0releasepnpminstead ofnpm