Skip to content

fix(test-utils): make google-test-utils a private workspace package - #9525

Merged
quirogas merged 4 commits into
mainfrom
fix-dependency-graph
Oct 6, 2026
Merged

fix(test-utils): make google-test-utils a private workspace package#9525
quirogas merged 4 commits into
mainfrom
fix-dependency-graph

Conversation

@quirogas

@quirogas quirogas commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Makes google-test-utils (core/test-utils) a private monorepo workspace package ("private": true), removes it from Release Please configuration, updates all current consumers (handwritten/spanner and handwritten/pubsub) to use "workspace:*", and updates handwritten/pubsub/cloudbuild.yaml to include upstream workspace dependencies during pnpm install.

@quirogas
quirogas requested review from a team as code owners October 5, 2026 22:43
@quirogas
quirogas added this pull request to stack #9526 October 5, 2026 22:43
@quirogas quirogas changed the title fix dependency graph fix(test-utils): make google-test-utils a private workspace package Oct 5, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 5, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request marks the core/test-utils package as private, removes it from the release-please configuration, and updates dependencies in pubsub and spanner to use the workspace version of google-test-utils. Feedback on the changes suggests reverting the pnpm filter modification in handwritten/pubsub/cloudbuild.yaml to avoid pulling in unnecessary downstream packages.

Comment thread handwritten/pubsub/cloudbuild.yaml Outdated
@github-actions
github-actions Bot requested a review from feywind October 5, 2026 23:24
@quirogas
quirogas removed the request for review from feywind October 6, 2026 06:00
@quirogas
quirogas force-pushed the fix-dependency-graph branch from 93d027b to 1b8dc2f Compare October 6, 2026 06:01
@github-actions
github-actions Bot requested a review from shivanee-p October 6, 2026 06:02
@quirogas
quirogas merged commit be25b6f into main Oct 6, 2026
46 checks passed
@quirogas
quirogas deleted the fix-dependency-graph branch October 6, 2026 14:09
This was referenced Oct 6, 2026
Merged
Open
shivanee-p pushed a commit that referenced this pull request Oct 6, 2026
@release-please
chore: release main (#9528)
4216dbe 
🤖 I have created a release *beep* *boop*
---


<details><summary>google-gax: 6.11.1</summary>

##
[6.11.1](google-gax-v6.11.0...google-gax-v6.11.1)
(2026-10-06)


### Bug Fixes

* **gax:** Only set resend_count on T4 attempt spans
([#9540](#9540))
([3b3f600](3b3f600))
* **gax:** Widen port to number | string in GrpcClientOptions
([#9542](#9542))
([17978e7](17978e7))
</details>

<details><summary>pubsub: 6.1.1</summary>

##
[6.1.1](pubsub-v6.1.0...pubsub-v6.1.1)
(2026-10-06)


### Bug Fixes

* **pubsub:** Align ClientConfig.port type with gax.GrpcClientOptions
([#9539](#9539))
([4443d6d](4443d6d))
* **test-utils:** Make google-test-utils a private workspace package
([#9525](#9525))
([be25b6f](be25b6f))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
shivanee-p added a commit that referenced this pull request Oct 6, 2026
@shivanee-p
Revert "fix(test-utils): make google-test-utils a private workspace p…
67ac5c9 
…ackage (#9525)"

This reverts commit be25b6f.
@shivanee-p shivanee-p mentioned this pull request Oct 6, 2026
Merged
shivanee-p added a commit that referenced this pull request Oct 6, 2026
@shivanee-p
chore(test-utils): revert making google-test-utils a private workspac…
34f8d61 
…e package (#9548)

Reverts #9525 (`be25b6fa1a6c6c90337ecad8afdcbcaeb477ded2`) to keep
`google-test-utils` (`core/test-utils`) as a published package managed
by Release Please, and updates consumer packages to depend on the
published `^0.2.0` release

- This is a temporary fix while we investigate if we can use `pnpm`
instead of `npm`
@release-please release-please Bot mentioned this pull request Oct 6, 2026
Merged
shivanee-p added a commit that referenced this pull request Oct 7, 2026
@release-please @shivanee-p
chore: release main (#9547)
d07cb88 
🤖 I have created a release *beep* *boop*
---


<details><summary>google-gax: 6.12.0</summary>

##
[6.12.0](google-gax-v6.11.1...google-gax-v6.12.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>gaxios: 8.2.0</summary>

##
[8.2.0](gaxios-v8.1.0...gaxios-v8.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>gcp-metadata: 9.1.0</summary>

##
[9.1.0](gcp-metadata-v9.0.4...gcp-metadata-v9.1.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>google-auth-library: 11.2.0</summary>

##
[11.2.0](google-auth-library-v11.1.0...google-auth-library-v11.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>googleapis-common: 9.2.0</summary>

##
[9.2.0](googleapis-common-v9.1.0...googleapis-common-v9.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>test-utils: 0.2.1</summary>

##
[0.2.1](test-utils-v0.2.0...test-utils-v0.2.1)
(2026-10-07)


### Bug Fixes

* **test-utils:** Make google-test-utils a private workspace package
([#9525](#9525))
([be25b6f](be25b6f))
</details>

<details><summary>bigquery: 9.2.0</summary>

##
[9.2.0](bigquery-v9.1.0...bigquery-v9.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>bigtable: 7.4.0</summary>

##
[7.4.0](bigtable-v7.3.0...bigtable-v7.4.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>datastore: 11.2.0</summary>

##
[11.2.0](datastore-v11.1.0...datastore-v11.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>error-reporting: 4.2.0</summary>

##
[4.2.0](error-reporting-v4.1.0...error-reporting-v4.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>dns: 6.2.0</summary>

##
[6.2.0](dns-v6.1.0...dns-v6.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>logging: 12.2.0</summary>

##
[12.2.0](logging-v12.1.0...logging-v12.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>logging-bunyan: 6.2.0</summary>

##
[6.2.0](logging-bunyan-v6.1.0...logging-bunyan-v6.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>logging-winston: 7.2.0</summary>

##
[7.2.0](logging-winston-v7.1.0...logging-winston-v7.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

<details><summary>pubsub: 6.2.0</summary>

##
[6.2.0](pubsub-v6.1.1...pubsub-v6.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))


### Bug Fixes

* **pubsub:** Avoid invoking callback inside promise handler in
getClient_
([#9544](#9544))
([752d1d7](752d1d7))
* **pubsub:** Pause underlying pull streams and skip keepalive teardown
while paused
([#9521](#9521))
([f863ecc](f863ecc))
</details>

<details><summary>translate: 10.2.0</summary>

##
[10.2.0](translate-v10.1.1...translate-v10.2.0)
(2026-10-07)


### Features

* **tools:** Add individual CLI flags for Bun monkey patches
([#9533](#9533))
([a5eec89](a5eec89))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Shivanee Persaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljbruce danieljbruce danieljbruce approved these changes
@shivanee-p shivanee-p Awaiting requested review from shivanee-p
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@danieljbruce danieljbruce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quirogas @danieljbruce