Repository navigation
fix(gax): only set resend_count on T4 attempt spans - #9540
Merged
Merged
Conversation
shivanee-p
marked this pull request as ready for review
October 6, 2026 17:52
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tracing logic in google-gax to ensure that resend counts are omitted from T3 client request spans and only recorded on T4 attempt spans. This is done by removing the recordResend recorder parameter from traceCall and updating the corresponding unit tests. However, a critical issue was identified in createApiCall.ts where omitting recordResend from the invokeCall arguments prevents the local recorder from being invoked during retries, which would incorrectly leave the resend count at zero on T4 attempt spans.
quirogas
approved these changes
Oct 6, 2026
Merged
shivanee-p
pushed a commit
that referenced
this pull request
Oct 6, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>google-gax: 6.11.1</summary> ## [6.11.1](google-gax-v6.11.0...google-gax-v6.11.1) (2026-10-06) ### Bug Fixes * **gax:** Only set resend_count on T4 attempt spans ([#9540](#9540)) ([3b3f600](3b3f600)) * **gax:** Widen port to number | string in GrpcClientOptions ([#9542](#9542)) ([17978e7](17978e7)) </details> <details><summary>pubsub: 6.1.1</summary> ## [6.1.1](pubsub-v6.1.0...pubsub-v6.1.1) (2026-10-06) ### Bug Fixes * **pubsub:** Align ClientConfig.port type with gax.GrpcClientOptions ([#9539](#9539)) ([4443d6d](4443d6d)) * **test-utils:** Make google-test-utils a private workspace package ([#9525](#9525)) ([be25b6f](be25b6f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates OpenTelemetry tracing in
google-gaxso that transport resend count attributes (gcp.grpc.resend_countandhttp.request.resend_count) are only recorded on per-attempt network spans (traceAttempt) and omitted from parent client request spans (traceCall)