Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Underlying error causing timeout not properly surfaced in normal/unary call retries #203

Closed
googleapis/gax-nodejs
#1650

Description

@leahecole

See internal bug 351328276 for more context. Based on this bug, I believe that we throw an error when the timeout is exceeded as part of the "normalCalls" retry cycle (https://github.com/googleapis/gax-nodejs/blob/d74fa409897468af5dba78ef60bb5d4c9defacb6/gax/src/normalCalls/retries.ts#L810) but it seems like the internal error that it was retrying on before timing out may be getting swallowed up by that retry cycle.

Steps to fix:

  • On timeout, add logic to make sure error is surfaced to the caller
  • Update unit tests (likely this one and similar ones around it, or add new ones)
  • Add a test or two or three to the test application. Might be a modification of echo error and/or could be a chance to write some tests against the regular (non-streaming) methods of the sequence client - this would look similar to some of our streaming tests, but would utilize CreateSequence and AttemptSequence to send a specific sequence of errors rather than CreateStreamingSequence and AttemptStreamingSequence

Activity

  1. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Aug 21, 2024
  2. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    and removed
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions