Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Rawresponse not being sent to the promise callback when pagination is not used #422

Closed
googleapis/gapic-generator-typescript
#171

Description

@Shrek-DevMasterRobo

I am using Talent-solution module for creating, updating and deleting Jobs. Also, in the meanwhile I am sending the client events as well, for which the request_id is required of the previous calls. But, when the API is being called without any pagination, the raw response is being sent back to the callback. Need this response in order to capture the request id.

Line that needs change - https://github.com/googleapis/gax-nodejs/blob/master/src/paginationCalls/pagedApiCaller.ts#L145

Need it changed to the following
canceller.callback(null, allResources, null, response);

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Nov 5, 2019
  2. bcoe commented on Nov 5, 2019

    @bcoe

    @Shrek-DevMasterRobo 👍 thank you for the bug report; would happily accept a failing test if you have time 👍

  3. alexander-fenster commented on Nov 6, 2019

    @alexander-fenster
    Contributor

    Hi @Shrek-DevMasterRobo, just to confirm - you're getting all the resources in the same "page" but still want to have rawResponse there, right? That's surely possible but I'd like to know more about the use case - which call is it?

    Also, if you don't need any auto-pagination at all and just need the response as is, pass { autoPaginate: false } as an options object for your request.

  4. Shrek-DevMasterRobo commented on Nov 6, 2019

    @Shrek-DevMasterRobo
    Author

    Hi @alexander-fenster , yes I still wanted the rawResponse. This was the Create Event for Cloud talent solution, where in the request ID is required in order to make it better.

    By using { autoPaginate: false } in the options, I got the response as I wanted, that helped.

    Thanks a lot @alexander-fenster !

  5. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions