Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

avoid unhandled promise rejection on wrongly initialized stub #494

Closed

Description

@jmuk

Reported as googleapis/google-cloud-node#2086:

We should avoid unhandled promise rejections. Right now each method holds a promise for the method of the grpc client instance; this should be avoided.

We should:

  • catch the error on createStub and throw an error
  • or probably we should avoid using promises at all, stub creation and authentication should be delayed and done for the first time a method is called

Activity

  1. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Mar 15, 2017
  2. stephenplusplus commented on Jul 20, 2018

    @stephenplusplus
    Contributor

    cc @johnviolano who reported htis over here: googleapis/nodejs-datastore#137

  3. jbolinger commented on Dec 10, 2018

    @jbolinger

    @alexander-fenster Any updates? Is this really a P1?

  4. landrito commented on Jan 2, 2019

    @landrito
    Contributor
  5. alexander-fenster commented on Jan 3, 2019

    @alexander-fenster
    Contributor

    This is reported as googleapis/gapic-generator#2065 and will be tracked there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions