Skip to content

Make logging system tests verbose. - #3244

Merged
lukesneeringer merged 1 commit into
masterfrom
issue-3237
Mar 30, 2017
Merged

lukesneeringer merged 1 commit into
masterfrom
issue-3237

Conversation

@lukesneeringer

Copy link
Copy Markdown
Contributor

@dhermes This is a more permanent change we can make for the logging system tests while we are watching them over the next few days.

@lukesneeringer lukesneeringer self-assigned this Mar 30, 2017
@lukesneeringer
lukesneeringer requested a review from dhermes March 30, 2017 16:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2017

@dhermes dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between level 2 (-vv) and level 3 (-vvv) verbosity? (I've never been able to determine any difference with py.test)

@dhermes

dhermes commented Mar 30, 2017

Copy link
Copy Markdown
Contributor

@lukesneeringer Are we worried that -vvv will leak secrets from env. vars?

@lukesneeringer

Copy link
Copy Markdown
Contributor Author

Wow, their docs are terrible on this. "Verbose" should not be a hard thing to search for.
I have no idea. Feel free to change it to -vv if you want.

@dhermes

dhermes commented Mar 30, 2017

Copy link
Copy Markdown
Contributor

No it's fine. Feel free to merge.

@lukesneeringer
lukesneeringer merged commit f638026 into master Mar 30, 2017
@lukesneeringer
lukesneeringer deleted the issue-3237 branch March 30, 2017 17:05
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants