Skip to content

Add Datastore resource-prefix header - #975

Merged
blowmage merged 6 commits into
googleapis:masterfrom
blowmage:grpc-project-metadata
Oct 15, 2016
Merged

Add Datastore resource-prefix header#975
blowmage merged 6 commits into
googleapis:masterfrom
blowmage:grpc-project-metadata

Conversation

@blowmage

@blowmage blowmage commented Oct 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add google-cloud-resource-prefix header to GRPC requests.

  • Datastore
  • Language
  • Logging
  • Pub/Sub
  • Speech
  • Vision

@blowmage blowmage added the grpc label Oct 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2016
@blowmage

blowmage commented Oct 14, 2016

Copy link
Copy Markdown
Contributor Author

@pcostell Can you verify this is the change you are looking for? Thanks!

@quartzmo

quartzmo commented Oct 14, 2016

Copy link
Copy Markdown
Member

Just a note:

The decision to use GAX CallOptions#kwargs is directed by @jmuk in this comment.

@quartzmo quartzmo added api: datastore Issues related to the Datastore API. gapic labels Oct 14, 2016
pcostell
pcostell reviewed Oct 14, 2016
View reviewed changes
Comment thread google-cloud-datastore/lib/google/cloud/datastore/service.rb
end

def default_headers
{ "google-cloud-resource-prefix" => "projects/#{@project}" }

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pcostell

pcostell commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

LGTM

@quartzmo

quartzmo commented Oct 14, 2016

Copy link
Copy Markdown
Member

I'll merge when green. (C'mon Travis CI)

@blowmage blowmage added api: compute Issues related to the Compute Engine API. api: logging Issues related to the Cloud Logging API. api: vision Issues related to the Cloud Vision API. api: speech Issues related to the Speech-to-Text API. api: language Issues related to the Cloud Natural Language API API. labels Oct 14, 2016
@blowmage

blowmage commented Oct 14, 2016

Copy link
Copy Markdown
Contributor Author

K, all GRPC services have the resource-prefix header. This is good to merge whenever the builds decide to finish.

@blowmage
blowmage merged commit e5b11db into googleapis:master Oct 15, 2016
@blowmage blowmage mentioned this pull request Oct 15, 2016
Closed
gcf-owl-bot Bot added a commit that referenced this pull request Jan 22, 2025
@gcf-owl-bot
feat: Update Compute Engine API to revision 20250107 (#975)
e80c397 
Source-Link: googleapis/googleapis@256da8c

Source-Link: googleapis/googleapis-gen@523a493
Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWNvbXB1dGUtdjEvLk93bEJvdC55YW1sIiwiaCI6IjUyM2E0OTMyODdhNjg1MmQ4NzE5ZDc1OTUyODlmNjFlZGRmY2MwMTAifQ==
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quartzmo quartzmo quartzmo left review comments
+1 more reviewer
@pcostell pcostell pcostell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: compute Issues related to the Compute Engine API. api: datastore Issues related to the Datastore API. api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. gapic grpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blowmage @quartzmo @pcostell @googlebot