This repository was archived by the owner on Aug 30, 2026. It is now read-only.
Repository navigation
fix(java): fix error message returned for invalid snapshot listener inequality filter - #1093
Merged
milaGGL merged 14 commits intoJan 24, 2023
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
milaGGL
changed the title
milaGGL
changed the title
milaGGL
changed the title
milaGGL
marked this pull request as ready for review
January 18, 2023 18:43
dconeybe
self-requested a review
January 18, 2023 18:47
dconeybe
suggested changes
Jan 20, 2023
dconeybe
approved these changes
Jan 24, 2023
milaGGL
deleted the
mila/fix-error-message-for-invalid-inequality-filter
branch
January 24, 2023 17:03
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
…nequality filter (#1093)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1085
While using multiple inequality filter, inequality on different properties are rejected as expected, with minor difference in error message.
In a normal query, the error message will display all the properties in the inequality filter.
While in a snapshot listener, the error message will only display the second property used the inequality filter.