Repository navigation
Merge Storage-NIO library into this repository. #242
Description
Activity
- changed the title
[-]Merge Storage-NIO library into Storage repository.[/-][+]Merge Storage-NIO library into this repository.[/+]on Apr 13, 2020 After discussing with @chingor13, the more likely approach is to separate out testing related code used by the Storage-Nio library into a separate artifact called google-cloud-storage-testing instead of merging Storage-NIO library into this repository.
Reacted by Ajit Thakor@frankyn, I this is about exporting FakeStorageRpc for the sake of testing I can take care of this issue to move it on. googleapis/google-cloud-java#12653 and #179 are currently blocked by this issue.
Suggested fix #345 creates a copy of
FakeStorageRpcfrom Storage-Nio in Storage. Because the main storage artifact already includes a testing package (com.google.cloud.storage.testing) the new class is placed there. No extra artifact is required.I verified, Storage-Nio could switch to the new
FakeStorageRpcclass without adding extra dependencies.
Currently have two repositories that must be merged into one library.
https://github.com/googleapis/java-storage-nio needs to be merged into this repository to unblock changes to the underlying internal only StorageRpc interface. Otherwise we can accidentally break users.