Merge Storage-NIO library into this repository. #242

Activity

1. frankyn

   self-assigned this

   on Apr 13, 2020
2. product-auto-label

   added

   api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.

   on Apr 13, 2020
3. frankyn

   changed the title [-]Merge Storage-NIO library into Storage repository.[/-] [+]Merge Storage-NIO library into this repository.[/+] on Apr 13, 2020
4. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   🚨This issue needs some love.This issue needs some love.

   on Apr 14, 2020
5. frankyn

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on Apr 20, 2020
6. frankyn commented on Apr 20, 2020

   

   frankyn

   on Apr 20, 2020

   ContributorAuthor

   More actions

   After discussing with @chingor13, the more likely approach is to separate out testing related code used by the Storage-Nio library into a separate artifact called google-cloud-storage-testing instead of merging Storage-NIO library into this repository.

   👍React with 👍1Reacted by Ajit Thakor
7. frankyn

   added

   status: investigatingThe issue is under investigation, which is determined to be non-trivial.The issue is under investigation, which is determined to be non-trivial.

   and removed

   🚨This issue needs some love.This issue needs some love.

   on Apr 20, 2020
8. dmitry-fa commented on May 20, 2020

   

   dmitry-fa

   on May 20, 2020

   Contributor

   More actions

   @frankyn, I this is about exporting FakeStorageRpc for the sake of testing I can take care of this issue to move it on. googleapis/google-cloud-java#12653 and #179 are currently blocked by this issue.
9. dmitry-fa commented on Jun 2, 2020

   

   dmitry-fa

   on Jun 2, 2020

   Contributor

   More actions

   Suggested fix #345 creates a copy of FakeStorageRpc from Storage-Nio in Storage. Because the main storage artifact already includes a testing package (com.google.cloud.storage.testing) the new class is placed there. No extra artifact is required.

   I verified, Storage-Nio could switch to the new FakeStorageRpc class without adding extra dependencies.
10. dmitry-fa

    self-assigned this

    on Jun 8, 2020
11. dmitry-fa commented on Jun 8, 2020

    

    dmitry-fa

    on Jun 8, 2020

    Contributor

    More actions

    FakeStorageRpc from #345 is very NIO specific, unlikely it will be used by anyone else. #351 provides a more generic approach: StorageRpcTestBase class implementing StorageRpc. FakeStorageRpc can extend StorageRpcTestBase.

    cc: @frankyn
12. frankyn

    closed this as completedin #351on Jun 8, 2020