This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Repository navigation
fix: Tests will now verify asynchronous termination of underlying steam, and fix related bug. - #1772
Merged
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
size: m
tom-andersen
force-pushed
the
tomandersen/fixClosingOfConnection
branch
from
September 14, 2022 14:07
6b6e4c6 to
d709194
Compare
tom-andersen
force-pushed
the
tomandersen/fixClosingOfConnection
branch
from
September 14, 2022 14:10
d709194 to
407df2e
Compare
tom-andersen
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
tom-andersen
marked this pull request as ready for review
September 14, 2022 14:11
ehsannas
reviewed
Sep 14, 2022
ehsannas
left a comment
ehsannas
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM. Thanks for the fix.
ehsannas
approved these changes
Sep 15, 2022
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [6.3.0](v6.2.0...v6.3.0) (2022-09-22) ### Features * Add aggregation query APIs ([#1765](#1765)) ([18be4d0](18be4d0)) ### Bug Fixes * Tests will now verify asynchronous termination of underlying steam, and fix related bug. ([#1772](#1772)) ([a1717ff](a1717ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Feb 24, 2026
🤖 I have created a release *beep* *boop* --- ## [6.3.0](googleapis/nodejs-firestore@v6.2.0...v6.3.0) (2022-09-22) ### Features * Add aggregation query APIs ([#1765](googleapis/nodejs-firestore#1765)) ([18be4d0](googleapis/nodejs-firestore@18be4d0)) ### Bug Fixes * Tests will now verify asynchronous termination of underlying steam, and fix related bug. ([#1772](googleapis/nodejs-firestore#1772)) ([a1717ff](googleapis/nodejs-firestore@a1717ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.