Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Retry settings sample's comments are a bit unclear #1189

Closed
#1374
Closed
Retry settings sample's comments are a bit unclear#1189
#1374
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.samplesIssues that are directly related to samples.type: docsImprovement to the documentation for an API.

Description

@feywind
feywind
opened on Jan 15, 2021

The comments are not 100% clear here about what this retryCodes array does, and that should probably be improved. (Report from a user, thank you!)

nodejs-pubsub/samples/publishWithRetrySettings.js

Line 71 in 057750b

// Retry settings control how the publisher handles retryable failures

Activity

  1. feywind
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: docsImprovement to the documentation for an API.
    api: pubsubIssues related to the googleapis/nodejs-pubsub API.
    on Jan 15, 2021
  2. product-auto-label
    added
    samplesIssues that are directly related to samples.
    on Jan 15, 2021
  3. yoshi-automation
    added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on Apr 15, 2021
  4. yoshi-automation
    added
    🚨This issue needs some love.
    on Jul 14, 2021
  5. feywind
    removed
    🚨This issue needs some love.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Jul 15, 2021
  6. gcf-merge-on-green
    closed this as completedin #1374on Aug 13, 2021
  7. gcf-merge-on-green
    added a commit that references this issue on Aug 13, 2021

    samples: make the comments for publishWithRetrySettings a bit more ve…

    d4bfc11
  8. feywind
    added a commit that references this issue on Nov 12, 2024

    chore(deps): update dependency jsdoc to v4 (googleapis#1189)

    99cdfbd
  9. feywind
    added a commit that references this issue on Mar 27, 2026

    samples: make the comments for publishWithRetrySettings a bit more ve…

    473c2ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: pubsubIssues related to the googleapis/nodejs-pubsub API.samplesIssues that are directly related to samples.type: docsImprovement to the documentation for an API.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions