Update system test PubSub calls or change PubSub deps #64

Activity

1. product-auto-label

   added

   api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.

   on Sep 16, 2020
2. sli2126 commented on Sep 16, 2020

   

   sli2126

   on Sep 16, 2020

   Author

   More actions

   Looks like it will be fixed in #62
3. sli2126

   closed this as completedon Sep 16, 2020
4. sli2126 commented on Oct 1, 2020

   

   sli2126

   on Oct 1, 2020

   Author

   More actions

   Looks like tests are still broken, re-opening.
5. sli2126

   reopened this on Oct 1, 2020
6. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   🚨This issue needs some love.This issue needs some love.

   on Oct 1, 2020
7. AlexanderFengFeng commented on Oct 1, 2020

   

   AlexanderFengFeng

   on Oct 1, 2020

   Last edited by AlexanderFengFeng

   More actions

   The primary reason that the PubSub version update is breaking tests is that in google-cloud-pubsub<2.0.0, parameters required by the API were positional parameters (like topic_path here) and optional parameters were keyword parameters. Now, following the 2.0.0 release, almost all methods that interact with the backend have a single positional parameter request.

   The change is best exemplified like so:

   Before:

   from google.cloud import pubsub
   
   publisher = pubsub.PublisherClient()
   
   project_path = "projects/{}".format(PROJECT_ID)
   topics = publisher.list_topics(project_path)

   After:

   from google.cloud import pubsub
   
   publisher = pubsub.PublisherClient()
   
   project_path = f"projects/{PROJECT_ID}"
   topics = publisher.list_topics(request={"project": project_path})

   There are two ways to resolve this:

   1. Change the PubSub dependency to "google-cloud-pubsub < 2.0.0" like @sli2126 mentioned by referencing storage's PR

   OR

   2. Change arguments in PubSub calls

   • create_topic: topic_path -> request={"name"=topic_path"}
   • get_iam_policy topic_path -> request={"resource": topic_path}
   • set_iam_policy topic_path, policy -> request={"resource": topic_path, "policy": policy}
   • delete_topic self.topic_path -> request={"topic"=self.topic_path}
8. simonz130

   assigned

   daniel-sanche

   on Oct 27, 2020
9. simonz130

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Oct 27, 2020
10. yoshi-automation

    removed

    triage meI really want to be triaged.I really want to be triaged.

    🚨This issue needs some love.This issue needs some love.

    on Oct 27, 2020
11. daniel-sanche commented on Dec 2, 2020

    

    daniel-sanche

    on Dec 2, 2020

    Contributor

    More actions

    This was fixed in #70
12. daniel-sanche

    closed this as completedon Dec 2, 2020