Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError - #2444

Merged
meltsufin merged 2 commits into
mainfrom
gh-1842
Feb 7, 2024
Merged

meltsufin merged 2 commits into
mainfrom
gh-1842

Conversation

@meltsufin

Copy link
Copy Markdown
Contributor
  • increase timeout from 2s to 30s to reduce the chance of DEADLINE_EXCEEDED before the NOT_FOUND message is received
  • keep separate low timeout for the testDeadlineExceededServerStreaming test
  • remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.

…nseError

* increase timeout from 2s to 30s to reduce the chance of DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
@meltsufin
meltsufin requested a review from a team February 7, 2024 02:25
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Feb 7, 2024
@meltsufin
meltsufin requested a review from suztomo February 7, 2024 02:26

@suztomo suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the test with a heavy load and it passed.

@meltsufin
meltsufin enabled auto-merge (squash) February 7, 2024 20:38
@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@meltsufin
meltsufin merged commit 564802b into main Feb 7, 2024
@meltsufin
meltsufin deleted the gh-1842 branch February 7, 2024 20:50
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
…nseError (#2444)

* increase timeout from 2s to 30s to reduce the chance of
DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming
test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gax-java(windows): HttpJsonDirectServerStreamingCallableTest.testOnResponseError- getCode()

2 participants