Skip to content

port forwarding should support port ranges #3750

Description

@rjmercier1

What is missing?

Openstack allows forwarding a range of ports in a single call using syntax like:
openstack floating ip port forwarding create --internal-protocol-port 15000:15099 ...
but gophercloud is forcing the type for these fields to be integer.

Activity

  1. winiciusallan commented on May 14, 2026

    @winiciusallan
    Contributor

    Per Neutron API documentation[1], we're indeed missing InternalPortRange and ExternalPortRange, so this looks like a valid bug.

    Would you like to give it a spin?

    [1] https://docs.openstack.org/api-ref/network/v2/index.html#port-forwarding-with-port-ranges

  2. rjmercier1 commented on May 15, 2026

    @rjmercier1
    Author
  3. winiciusallan commented on May 15, 2026

    @winiciusallan
    Contributor

    Great to hear that you've managed the issue.

    I'm not the one who cuts the releases, but I'd say that this change should be made in a minor version, instead of a patch, since we follow semver and this is an API change. A maintainer can confirm this.

    In normal circumstances, we (or you) would implement your changes for v2.13.0 and ask for the terraform-provider-openstack maintainer(s) to bump gophercloud version so you can have your feature there.

    If you are ok with this, feel free to submit a PR against the main branch. I'll be happy to review it 😃

  4. rjmercier1 commented on May 15, 2026

    @rjmercier1
    Author
  5. winiciusallan commented on May 15, 2026

    @winiciusallan
    Contributor

    Whelp, I’m sure I did it wrong but I opened a PR for this. The issue is 3750.

    It looks like you pushed a commit from an old branch. I highly recommend that you take a look at the contribution guide.

    We merge changes into the main branch and backport non-breaking changes to V2 or V1. That being said, you should create a new branch from the main and push it (I believe it is okay if you create a fresh PR for this).

    If you need some help from my side, let me know.

  6. rjmercier1 commented on May 15, 2026

    @rjmercier1
    Author
  7. winiciusallan commented on May 18, 2026

    @winiciusallan
    Contributor

    @rjmercier1 In the previous message, I was talking about the PR that you closed. Regarding your actual PR (#3756), it is all good.

  8. rjmercier1 commented on May 18, 2026

    @rjmercier1
    Author
  9. winiciusallan commented on May 18, 2026

    @winiciusallan
    Contributor

    Ok, so you need me to update the test cases. It’s going to take me a bit because I can’t run the tests agains our production

    Feel free to join us at #gophercloud in the Kubernetes slack workspace if you need some help :)

  10. rjmercier1 commented on May 19, 2026

    @rjmercier1
    Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions