Skip to content

core: reauthentication waits ignore context cancellation #3922

Description

@rm-you

What happened?

When reauthentication is already in progress, another request waits in reauthFuture.Get() without observing its context. A canceled request can therefore remain blocked until the active reauthentication completes.

After successful reauthentication, a failed retry is returned as ErrErrorAfterReauthentication. The error does not unwrap ErrOriginal, so ResponseCodeIs cannot detect status codes such as 404.

Expected behavior: a waiting request returns ctx.Err() when canceled without interrupting the active reauthentication, and the retried request error remains available through standard error unwrapping.

Version

v2 (current)

Activity

  1. rm-you commented on Aug 7, 2026

    @rm-you
    ContributorAuthor

    Implementation and regression tests: #3939

  2. changed the title [-]Make reauthentication waits context-aware[/-] [+]core: reauthentication waits ignore context cancellation[/+] on Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions