Repository navigation
core: honor context while waiting for reauthentication - #3939
Merged
Merged
Conversation
github-actions
Bot
added
the
edit:gophercloud
rm-you
force-pushed
the
fix/context-aware-reauth
branch
from
August 12, 2026 06:30
a2477f3 to
1fb4f74
Compare
rm-you
changed the title
rm-you
changed the title
rm-you
marked this pull request as ready for review
August 12, 2026 06:44
github-actions
Bot
added
semver:minor
|
coverage: 63.557% (+0.01%) from 63.544% — rm-you:fix/context-aware-reauth into gophercloud:main |
stephenfin
requested changes
Aug 13, 2026
stephenfin
left a comment
stephenfin
left a comment
Contributor
There was a problem hiding this comment.
This looks pretty good. Couple of comments/questions inline before I sign off though
rm-you
force-pushed
the
fix/context-aware-reauth
branch
from
August 13, 2026 20:38
1fb4f74 to
f2a09ac
Compare
stephenfin
approved these changes
Aug 14, 2026
Contributor
Author
|
So now we need to backport to v2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3922
A request waiting for another goroutine's reauthentication ignores its context and can remain blocked past its deadline. This change lets the waiter return
ctx.Err()without interrupting the active reauthentication.ErrErrorAfterReauthenticationnow unwraps the retried request error, allowingResponseCodeIsto detect status codes such as 404.Links to the line numbers/files in the OpenStack source code that support the code in this PR:
N/A. This changes client-side synchronization and error handling.