Skip to content

compute/v2: Hypervisors List API - #344

Merged
jtopjian merged 9 commits into
gophercloud:masterfrom
jtopjian:compute_hypervisors_list
May 19, 2017
Merged

compute/v2: Hypervisors List API#344
jtopjian merged 9 commits into
gophercloud:masterfrom
jtopjian:compute_hypervisors_list

Conversation

@jtopjian

@jtopjian jtopjian commented May 18, 2017

Copy link
Copy Markdown
Contributor

For #179
Supersedes #178

spjmurray and others added 8 commits February 20, 2017 11:40
@spjmurray
Nova Hypervisors API
530d34d 
Adds in support to list all available hypervisors (detailed) for applications
such as monitoring and capacity planning.

For gophercloud#179
@spjmurray
Fix more API weirdness
1e0bb47 
For some reason this morning storage space started to (in gophercloud only
not via curl) return sizes as scientific notation
@spjmurray
Stylistic changes for jrperritt
5d5e2c0
@spjmurray
Change to be a marker paged type
e0feaf7
@spjmurray
Revert to single page results
4202358 
Our environment doesn't support marker pages, so go for the backwards compatible
option.
@jtopjian
Format and consistency fixes for hypervisor api
3caa84b
@jtopjian
Moving hypervisors to extensions
fb02eee
@jtopjian
Adding hypervisors acceptance test
e72a0d7
@jtopjian

jtopjian commented May 18, 2017

Copy link
Copy Markdown
Contributor Author

@jrperritt Quick question: SinglePage returns still follow the same EachPage and AllPage patterns as other page types, right? Other SinglePage returns in Gophercloud are doing this, just want to explicitly ask :)

@coveralls

coveralls commented May 18, 2017 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 69.964% when pulling c0ec39c on jtopjian:compute_hypervisors_list into cdf764f on gophercloud:master.

@jrperritt

jrperritt commented May 18, 2017

Copy link
Copy Markdown
Contributor

Yes. AllPages returns immediately for SinglePages (with the first (and only) page).

@jtopjian

jtopjian commented May 19, 2017

Copy link
Copy Markdown
Contributor Author

This looks good to me. I'm going to go ahead and merge it. @spjmurray Thank you for your work on this :)

@jtopjian
jtopjian merged commit baa2eb4 into gophercloud:master May 19, 2017
@jtopjian jtopjian mentioned this pull request May 19, 2017
Closed
@jtopjian

jtopjian commented May 20, 2017

Copy link
Copy Markdown
Contributor Author

Ping @majewsky - This might be useful for Limes (which I'm looking at because we have a similar in-house quota management system 😄 )

@majewsky

majewsky commented May 20, 2017

Copy link
Copy Markdown
Contributor

Thanks for pinging. @auhlig Do you want to adjust the Nova capacity plugin to take advantage of this?

Re Limes, I'd be delighted to see someone outside SAP use it. If you have any questions or requirements, feel free to open an issue over in our repo.

@auhlig

auhlig commented May 20, 2017

Copy link
Copy Markdown

Sure. Thanks for the hint @majewsky

@auhlig auhlig mentioned this pull request May 20, 2017
Closed
@jtopjian
jtopjian deleted the compute_hypervisors_list branch April 24, 2018 03:11
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
@jtopjian
Merge pull request gophercloud#344 from jtopjian/fwaasv1-projectid-fix
23d014f 
FWaaS v1: fixing rule acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jtopjian @coveralls @jrperritt @majewsky @auhlig @kenperkins @spjmurray