Repository navigation
Fix clouds.yaml search path to use XDG convention on all platforms - #3649
Merged
Merged
Conversation
github-actions
Bot
added
edit:config
mandre
previously approved these changes
Mar 10, 2026
mandre
left a comment
mandre
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I believe this doesn't change the behavior on Linux but makes it more consistent across platforms.
mandre
reviewed
Mar 10, 2026
mandre
left a comment
mandre
left a comment
Contributor
There was a problem hiding this comment.
Would it be possible to add a unit test for the fallback mechanism?
Contributor
Author
|
Of course, ill work on it |
os.UserConfigDir() returns ~/Library/Application Support on macOS, which doesn't match the OpenStack standard. Use XDG_CONFIG_HOME with a ~/.config fallback instead.
jlarriba
force-pushed
the
fix-clouds-xdg-path
branch
from
March 20, 2026 08:32
b89a925 to
74130d7
Compare
Contributor
Author
Added specific unit tests for the new mechanism |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.UserConfigDir() returns ~/Library/Application Support on macOS, which doesn't match the OpenStack standard. Use XDG_CONFIG_HOME with a ~/.config fallback instead.
Fixes #3496