Skip to content

subnetpool: Support for add and remove prefixes operations - #3854

Merged
mandre merged 3 commits into
gophercloud:mainfrom
winiciusallan:subnetpool-prefix-ops
Aug 19, 2026
Merged

mandre merged 3 commits into
gophercloud:mainfrom
winiciusallan:subnetpool-prefix-ops

Conversation

@winiciusallan

Copy link
Copy Markdown
Contributor

This PR adds the API calls for add and remove prefixes within the Subnet Pool API

Fixes #3850

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/network/v2/index.html#subnet-pool-prefix-operations-subnetpool-prefix-ops

@github-actions github-actions Bot added edit:networking This PR updates networking code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Jul 14, 2026
@coveralls

coveralls commented Jul 14, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 63.565% (+0.02%) from 63.545% — winiciusallan:subnetpool-prefix-ops into gophercloud:main

@dlaw4608 dlaw4608 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @winiciusallan looks good, just a few things I noticed nothing major, and that failure looks like a flake nothing to do with your code.

Comment thread openstack/networking/v2/extensions/subnetpools/testing/fixtures_test.go Outdated
Comment thread openstack/networking/v2/extensions/subnetpools/requests.go Outdated
Comment thread openstack/networking/v2/extensions/subnetpools/requests.go Outdated
stephenfin
stephenfin previously approved these changes Aug 7, 2026
@stephenfin

Copy link
Copy Markdown
Contributor

Looks like @dlaw4608's comments were all resolved.

@stephenfin
stephenfin enabled auto-merge August 7, 2026 13:00
@stephenfin
stephenfin added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 7, 2026
@winiciusallan
winiciusallan force-pushed the subnetpool-prefix-ops branch from 7d0406a to 381d5ad Compare August 10, 2026 11:35
@stephenfin
stephenfin enabled auto-merge August 12, 2026 10:17
@stephenfin

stephenfin commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Those CI failures will be fixed by #3945. I guess we'll have to rebase this once that merges? 😕

auto-merge was automatically disabled August 17, 2026 18:16

Head branch was pushed to by a user without write access

@winiciusallan
winiciusallan force-pushed the subnetpool-prefix-ops branch from 381d5ad to 147f6e2 Compare August 17, 2026 18:16
@mandre
mandre added this pull request to the merge queue Aug 19, 2026
Merged via the queue into gophercloud:main with commit bda5aa7 Aug 19, 2026
137 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:networking This PR updates networking code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for subnet pool prefixes operations add/remove

5 participants