Repository navigation
pagination: Fix AllPages returning wrong key for empty linked pages - #3945
Merged
Merged
Conversation
When AllPages() processes a linked page where all results are empty,
EachPage returns early without invoking the callback (because IsEmpty
returns true). This left the resource key unset (empty string ""),
producing a body like {"": nil} instead of {"networks": []}.
This was harmless until b80f371 added validation in extractIntoPtr
that correctly rejects responses missing the expected key, causing
ExtractNetworks (and similar) to fail with "expected response key
not found in response" on empty list results.
Fix by discovering the resource key from the first page body before
calling EachPage, rather than inside the callback.
Signed-off-by: Stephen Finucane <[email protected]>
Assisted-By: Claude Opus 4.6 <[email protected]>
github-actions
Bot
added
edit:gophercloud
|
coverage: 63.549% (+0.005%) from 63.544% — shiftstack:fix-paging into gophercloud:main |
winiciusallan
approved these changes
Aug 14, 2026
stephenfin
enabled auto-merge
August 14, 2026 13:30
This was referenced Aug 14, 2026
Contributor
Author
|
I think this needs to be backported to |
stephenfin
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Aug 19, 2026
Commit 0e6c7c7 (gophercloud#3945) ensured how we retrieve the key from a response body, ensuring we don't get skip this if the page is empty. However, we still re-evaluate the key for each page rather than using the key we determined once. This is wasteful and unnecessary complexity. Fix it now, ahead of the introduction of KeyedPage. Signed-off-by: Stephen Finucane <[email protected]>
winiciusallan
pushed a commit
to shiftstack/gophercloud
that referenced
this pull request
Aug 20, 2026
Commit 0e6c7c7 (gophercloud#3945) ensured how we retrieve the key from a response body, ensuring we don't get skip this if the page is empty. However, we still re-evaluate the key for each page rather than using the key we determined once. This is wasteful and unnecessary complexity. Fix it now, ahead of the introduction of KeyedPage. Signed-off-by: Stephen Finucane <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
AllPages()processes a linked page where all results are empty,EachPagereturns early without invoking the callback (becauseIsEmptyreturnstrue). This left the resource key unset (empty string""), producing a body like{"": nil}instead of{"networks": []}.This was harmless until b80f371 added validation in
extractIntoPtrthat correctly rejects responses missing the expected key, causingExtractNetworks(and similar) to fail with "expected response key not found in response" on empty list results.Fix by discovering the resource key from the first page body before calling
EachPage, rather than inside the callback.