Repository navigation
[v2] CI: improve test assertions - #3930
Merged
Merged
Conversation
github-actions
Bot
added
edit:networking
|
coverage: 63.842% (-0.03%) from 63.871% — shiftstack:bp-v2-3777 into gophercloud:v2 |
Contributor
Author
|
I think needs a backport of #3945 |
All equality assertion helpers (AssertEquals, CheckEquals, AssertDeepEquals,
CheckDeepEquals, etc.) expect (t, expected, actual) but many call sites had
the arguments swapped, putting the actual value first and the expected
literal second. This causes confusing error messages on test failure.
Conflicts:
internal/acceptance/openstack/identity/v3/endpoint_test.go
internal/acceptance/openstack/networking/v2/extensions/security_test.go
NOTE(stephenfin): Conflicts are due to the absence of commits 57d6a12
and c759860, both of which change fields to pointers to allow them to
be unset and neither of which are backportable.
Fix bugs where assertions compared the wrong field or compared a value to itself, silently passing due to empty string values.
Add AssertTrue, AssertFalse, CheckTrue, CheckFalse for boolean
assertions, and AssertEqualsIgnoreCase, CheckEqualsIgnoreCase for
case-insensitive string comparisons.
Replace all existing uses of AssertEquals and CheckEquals with boolean
literal arguments to use the new helpers instead.
Conflicts:
internal/acceptance/openstack/loadbalancer/v2/loadbalancer.go
NOTE(stephenfin): Conflicts are due to commits c9703e7 and
832af4f, which change a field to a pointer and rename a field,
respectively. Neither are backportable.
Contributor
|
I think we need to backport #3765 to V2 so we can run Magnum jobs. Created a manual backport for this #3954
|
mandre
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #3777, with the last commit skipped due to the large number of merge conflicts. 2 of the 3 remaining commits also have merge conflicts but these are relatively trivial and documented in the commit message.
We want this change mainly due to the addition of the new test assertion helpers, which are relying on in
main.