Repository navigation
Identity v3: Users Create - #392
Conversation
|
With regard to how "extras" are handled here, it's hard to determine from the Keystone code. The This also means that I'll modify |
|
Found a nit: changing |
878df2d to
e5d9c69
Compare
| // Extra are free-form extra key/value pairs to describe the user. | ||
| Extra map[string]interface{} `json:"-"` | ||
|
|
||
| // Options are coded 4-character options defined by the API. |
There was a problem hiding this comment.
What does "coded 4-character options" mean?
There was a problem hiding this comment.
You're too quick :)
Yes, I'll fix this. In the Keystone code, these are actually stored as 4-character codes. But then I found out that the readable-name is used and forgot to change this.
| Extra map[string]interface{} `json:"-"` | ||
|
|
||
| // Options are coded 4-character options defined by the API. | ||
| Options map[Options]interface{} `json:"options,omitempty"` |
There was a problem hiding this comment.
Is this map's value type an interface only because of MultiFactorAuthRules?
There was a problem hiding this comment.
Yes, otherwise it would have been strict bool.
| "password": "secretsecret", | ||
| "email": "[email protected]", | ||
| "options": { | ||
| "ignore_password_expiry": true |
There was a problem hiding this comment.
Let's have at least the non-boolean option in here as an example.
|
LGTM |
|
Thanks! |
* Identity v3: Users Create * Identity v3: Users Create unit tests * Identity v3: Users Create acceptance tests * Identity v3 Users: code review updates
Unit test cases for host controller - Test cases written for utility funcitons in host controller - Test coverage for host_controller_test.go is 46.7% Signed-off-by: vineela-pachchipulusu <[email protected]>
3 participants
For #287