Repository navigation
[v2] pagination: Fix AllPages returning wrong key for empty linked pages - #3952
Merged
Merged
Conversation
When AllPages() processes a linked page where all results are empty,
EachPage returns early without invoking the callback (because IsEmpty
returns true). This left the resource key unset (empty string ""),
producing a body like {"": nil} instead of {"networks": []}.
This was harmless until b80f371 added validation in extractIntoPtr
that correctly rejects responses missing the expected key, causing
ExtractNetworks (and similar) to fail with "expected response key
not found in response" on empty list results.
Fix by discovering the resource key from the first page body before
calling EachPage, rather than inside the callback.
Signed-off-by: Stephen Finucane <[email protected]>
Assisted-By: Claude Opus 4.6 <[email protected]>
github-actions
Bot
added
v2
|
coverage: 63.871% (+0.006%) from 63.865% — bp-v2-0e6c7c7 into v2 |
mandre
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #3945
When
AllPages()processes a linked page where all results are empty,EachPagereturns early without invoking the callback (becauseIsEmptyreturnstrue). This left the resource key unset (empty string""), producing a body like{"": nil}instead of{"networks": []}.This was harmless until b80f371 added validation in
extractIntoPtrthat correctly rejects responses missing the expected key, causingExtractNetworks(and similar) to fail with "expected response key not found in response" on empty list results.Fix by discovering the resource key from the first page body before calling
EachPage, rather than inside the callback.