Repository navigation
[v2] test(db): use datastore-appropriate config parameter in TestConfigurationsCRUD - #3992
Merged
Merged
Conversation
…tionsCRUD Trove's devstack plugin (commit 25dde62d8f0b) now registers three datastores (mysql, mariadb, postgresql) instead of just mysql. Our script/stackenv picks whichever openstack datastore list returns first, which is non-deterministic. When postgresql is selected, the test fails because collation_server is a MySQL/MariaDB-only parameter. Use max_connections for PostgreSQL and keep collation_server for MySQL/MariaDB. Fixes #3982
github-actions
Bot
added
edit:db
|
coverage: 63.94%. remained the same — bp-v2-546e89e into v2 |
mandre
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #3990
Trove's devstack plugin (commit 25dde62d8f0b) now registers three datastores (mysql, mariadb, postgresql) instead of just mysql. Our script/stackenv picks whichever openstack datastore list returns first, which is non-deterministic. When postgresql is selected, the test fails because collation_server is a MySQL/MariaDB-only parameter.
Use max_connections for PostgreSQL and keep collation_server for MySQL/MariaDB.
Fixes #3982