Repository navigation
reservation: add leases resources - #4031
Conversation
github-actions
Bot
added
edit:reservation
|
coverage: 63.641% (+0.03%) from 63.614% — barnes-c:reservation-leases into gophercloud:main |
2ab5176 to
a94b6ce
Compare
Adds the `leases` package to the Reservation (Blazar) v1 service client, covering the Lease suite of the api-ref Signed-off-by: Christopher Barnes <[email protected]>
a94b6ce to
1637712
Compare
That's only because we needed your first patch that created the CI job in v2 (automation couldn't backport it automatically to v2 because the job structure is different between master and v2). Once the CI job landed in v2, I simply rebased the PR, as I recall. |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Again, really nice work. Just a small question about the affinity fields, otherwise looks ready to merge.
Thanks for reviewing again! I got the resource allocations PR also almost ready. Regarding the floating IPs though, I cannot test in our own cloud since we dont support those ATM Would you welcome it if I start making PRs to ORC for it to also have Blazar support? |
Nice, looking forward to it.
We should be able to test in CI with devstack, shouldn't we?
More than welcome, in fact. That would be really great. Thanks a lot for all the contributions. |
I remember reading that testing and fixtures should come from a real cloud so I was not sure. If thats not a problem Im happy to contribute this too |
3 participants
Hi!
For #3987
This PR adds the
leasespackage for the Reservation (Blazar) service ,covering the Leases suite of the api-ref:ListGET /leasesCreatePOST /leasesGetGET /leases/{lease_id}UpdatePUT /leases/{lease_id}DeleteDELETE /leases/{lease_id}/v1(v1_0.py#L31)Resthelper (utils.py#L47-L60).%Y-%m-%d %H:%Mformat (service.py#L62).I saw that the previous MR which introduced the host resources, required some manual backporting. Is there something I can do to help with this?
Related:
#3988
#3304
#3406