Repository navigation
[Pending #435] [Pending #436] Switch service client.microversion from string to microversion type - #437
Closed
pospispa wants to merge 3 commits into
Conversation
Some Manila service API requests are supported from a particular microversion. Therefore, it will be needed to compare two different microversions in order to find out if an API request is supported or not. That's why the a data type Microversion with methods for parsing and comparing microversions is added.
Some Manila service API requests are supported from a particular microversion. Therefore, it will be needed to compare two different microversions in order to find out if an API request is supported or not. That's why the Microversion was reworked to be of type internal.Microversion.
pospispa
changed the title
Contributor
Author
|
Started using |
Contributor
Author
|
Closing this PR so that microservices can be discussed as a whole in #441 |
msheikh-wind
pushed a commit
to msheikh-wind/gophercloud
that referenced
this pull request
May 19, 2025
…#437) Test plan: PASS: 'make' and 'make test' ran successfully PASS: deployctl tool generates the cluster-host platformNetworks and addresspools without --minimal-config PASS: deployctl tool doesnot generate cluster-host platformNetworks and addresspools with --minimal-config Signed-off-by: vineela-pachchipulusu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #315, #380
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
N/A