Repository navigation
Extensions Refactor - #443
Conversation
|
I'm not sure if this PR could be broken up into separate ones. I believe a change in any of these will cause tests to fail in other areas. |
|
Thanks for digging into this! After skimming it, the first thing I'd like to see are several pass/fail scenarios run via unit tests for |
Ah, yeah, that's a good point. I'll look at this sometime this weekend. I think the Travis error is with Travis itself. All tests pass locally. |
|
From Travis:
|
This commit refactors the external network extension by doing two things: 1. It extends the base Network CreateOpts with an External field rather than maintaining a separate copy of CreateOpts. 2. It provides the ability to extend the results with the `router:external` field.
439cc7e to
8a4d7f5
Compare
|
You have a better eye than me! |
5ef19f5 to
a1e3688
Compare
|
@jrperritt Let me know if there are any other scenarios you had in mind. |
a1e3688 to
62e140d
Compare
1 similar comment
|
Yay! Thanks! |
* Network v2: Updating networks to support extensions * Network v2: Network unit test cleanup * Network v2: Provider Extension * Network v2: Provider Extension unit tests * Core: Handle nested JSON unmarshaling * Network v2: Refactor External Network extension This commit refactors the external network extension by doing two things: 1. It extends the base Network CreateOpts with an External field rather than maintaining a separate copy of CreateOpts. 2. It provides the ability to extend the results with the `router:external` field. * Core: Unit tests for unmarshaling results
This commit will format IPv6 records in a way that the DNSaaS / Designate service expects them to be. Notably, it strips the brackets from the addresses. Passing IPv6 records with brackets already removed still works.
…hercloud#443) When system controller is ready, it will notify all the other reconcilers about the ready state, so the other controllers can start the reconciliation loop. This commit ensures that the system controller can notify the other controller even if the last iteration failed to call the webhook, but the system is reconciled. Test Case: - PASS: Deploy AIO-SX
3 participants
For #300